/usr/src/hylafax-v4.0pl1/util/TextFmt.*.patch

http://www.lege.com/hylafax-v4.0pl1-util-TextFmt.html





Pick up the two patches here


Here's the postings about the above patches in the HylaFax mailinglist


From leif@lege.com Sat Jan  3 00:25:38 1998
Date: Fri, 2 Jan 1998 19:09:39 +0100 (MET)
From: Leif Erlingsson <leif@lege.com>
To: Steve Williams <steve@genie96.com>
Cc: flexfax@sgi.com, Sam Leffler <sam@engr.sgi.com>
Subject: flexfax: Does anyone know if my patches for 8bit iso8859-1
	 international character sets will make it into the main
	 distribution?

Does anyone know if my patches for 8bit iso8859-1 international
character sets will make it into the main distribution?

	/usr/src/hylafax-v4.0pl1/util/TextFmt.h.patch
	/usr/src/hylafax-v4.0pl1/util/TextFmt.c++.patch

These patches, that was posted here on the flexfax list back in
February 1997;	Date: Thu, 13 Feb 1997 07:06:24 +0100 (MET);
Subject: TextFmt.c++/.h & ISO-8859-1; Solution: (unsigned const..;
solves the bug with signed characters that makes 8bit iso8859-1
characters difficult to handle when converting from iso8859-1 text
in email and otherwise.

(Matthias Apitz wrote back later the same day with a list of all changes which will make it into the upcoming pl2.     util/TextFmt.h and util/TextFmt.c++ will incorporate my patches, which "solves ``textfmt'' bugs on any platform/any OS; no more problems with international character sets and textfmt! Submitted by leif@lege.com (Leif Erlingsson), 13 Feb 1997 patch06".)
The patches are very small, but I don't like to post them anyway,
so I'll add them to my web-site as:

	http://www.lege.com/hylafax-v4.0pl1-util-TextFmt.h.patch
	http://www.lege.com/hylafax-v4.0pl1-util-TextFmt.c++.patch

Just re-name them

	/usr/src/hylafax-v4.0pl1/util/TextFmt.h.patch
	/usr/src/hylafax-v4.0pl1/util/TextFmt.c++.patch

and apply them using

	cd /usr/src/hylafax-v4.0pl1/util
	patch < TextFmt.h.patch
	patch < TextFmt.c++.patch

and make real clean (read the README's and INSTALL's) and re-
compile!	(It was nearly a year ago I did this so I don't
remember how, there is a very good web-site about HylaFax at
http://www.vix.com, check that out if you need assistance!)


Q2: Who is today "official maintainer" of the HylaFax source?
Is it still Sam Leffler <sam@engr.sgi.com>?  I never heard from
him after my February 1997 post, that was To: him.

(Sam Leffler very quickly wrote back to say that it is today Matthias Apitz <Matthias.Apitz@softcon.de> who is "official maintainer" of the HylaFax source.)

Q3: Is there anything at all going on with the HylaFax project
anymore?
   

Thanks!

__________________________________________________________________

Here's a transcript of my Feb 13, 1997 post:
__________________________________________________________________

Date: Thu, 13 Feb 1997 07:06:24 +0100 (MET)
From: Leif Erlingsson <leif@lege.com>
To: Sam Leffler <sam@hyla.chez.sgi.com>
Cc: Jan Clareus <jancla@rsv.se>, Reine Persson <reiper@rsv.se>,
    flexfax@sgi.com, Anders Wass <andwas@rsv.se>
Subject: TextFmt.c++/.h & ISO-8859-1; Solution: (unsigned const char) kludge;
TextFmt.h.patch TextFmt.c++.patch
Parts/attachments:
   1 Shown    52 lines	Text
   2   OK   ~1.4 KB	Text, "/usr/src/hylafax-v4.0pl1/util/TextFmt.h.patch"
   3   OK   ~2.1 KB	Text, "/usr/src/hylafax-v4.0pl1/util/TextFmt.c++.patch
----------------------------------------


/usr/src/hylafax-v4.0pl1/util/TextFmt.h.patch
/usr/src/hylafax-v4.0pl1/util/TextFmt.c++.patch

Above patches solves ``textfmt'' bugs on any platform/any OS and if
applied by hand, applicable also to older versions of hylafax. Now no
more problems with international character sets and textfmt!


Hi Sam,

	have inserted ``(unsigned const char)'' in TextFmt.h and have
added a few lines to hylafax-v4.0pl1/util/TextFmt.c++ to make it function
better in an international environment and with bad data in the upper
character-codes of the metrics-files in the distribution.

Find commented patches attached. Feel free to remove the comments, they
are just there to tell you and others why I did what I did.


The above patches have been thoroughly tested by me. They work well. They
fix a programming error where values in an array are selected using
*negative* indices, causing random memory addresses to be refereced. This
is the cause of much pain in the international Hylafax community. Help is
on it's way! Especially, TextFmt.h.patch solves the worst problem, but
TextFmt.c++.patch may also be neccessary + that it solves minor errors in
the processing of font width data from font metrics files by ignoring data
in the files for character values above 127, because the supplied font
metrics files cannot reliably be used for values above 127 -- iso 8859-1,
instead it uses the same default Sam uses when no font metrics files are
found, but only for values above 127, values up to 127 are read as before.

__________________________________________________________________


So, I repeat my questions, in case anyone forgot it among all the
above verbiage, [ :-) ]  does anyone know if my patches for 8bit
iso8859-1 international character sets will make it into the main
HylaFax distribution?

Q2: Who is today "official maintainer" of the HylaFax source?
Is it still Sam Leffler <sam@engr.sgi.com>?  I never heard from
him after my February 1997 post.
   
(Sam Leffler very quickly wrote back to say that it is today Matthias Apitz <Matthias.Apitz@softcon.de> who is "official maintainer" of the HylaFax source, and Matthias Apitz wrote back later the same day with a list of all changes which will make it into the upcoming pl2.     The list includes the above patches.

Q3: Is there anything at all going on with the HylaFax project
anymore?


Thanks!

__________________________________________________________________
Leif Erlingsson                 Tel     +46 8 604-0995
DATA LEGE                       Fax     +46 8 605-2551
Glavagatan 33                   URL     http://www.lege.com
123 71  Farsta,  Sweden         Email   mailto:leif@lege.com
__________________________________________________________________
I remember the past.  I am not doomed to buy Microsoft products.


HOME


Copyright © 1998 DATA LEGE

Updated January 23, 1998